Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notice for serializers #1

Merged
merged 1 commit into from
Nov 30, 2017
Merged

add notice for serializers #1

merged 1 commit into from
Nov 30, 2017

Conversation

zvictor
Copy link
Contributor

@zvictor zvictor commented Nov 29, 2017

No description provided.

@zvictor zvictor changed the title add notice for caveats add notice for serializers Nov 29, 2017
@igor-dv
Copy link
Owner

igor-dv commented Nov 30, 2017

@zvictor, thanks for the PR.
I have an idea of how to support the custom serializers, will need some time to get back to it. But meanwhile, I am approving this PR.

@igor-dv igor-dv merged commit a6d58ba into igor-dv:master Nov 30, 2017
@zvictor zvictor deleted the patch-1 branch November 30, 2017 15:15
@zvictor
Copy link
Contributor Author

zvictor commented Nov 30, 2017

@igor-dv is there anything you need help with?
maybe you could try explaining your idea so the community can give it a try.

given that the mentioned jest-specific-snapshot is crucial in my setup, I would be willing to spend some time digging into it.

@igor-dv
Copy link
Owner

igor-dv commented Nov 30, 2017

This plugin is a bit "hacky". It overrides the toMatchSnapshot method from the jest-snapshot package directly. After that, the regular way of adding serializers stopped to work. Looks like the jest's serializers collection have another instance during the test than the one used in the overridden plugin. So what I wanted to do is just to provide the way to add serializers for this plugin separately by exposing the addSerializer method from the jest-snapshot package as well. Surely it's not a perfect solution - but a workaround. I didn't have time to check this. Of course, you are welcome to take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants